Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent slow field lookups when JSON fields are present. #39872

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

jtibshirani
Copy link
Contributor

We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.

@jtibshirani jtibshirani added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types labels Mar 9, 2019
@jtibshirani jtibshirani requested a review from romseygeek March 9, 2019 03:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice to try and test the short-circuit behaviour, but there isn't really any way to determine if it has kicked in or not, so I'm fine with the tests as they are.

We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
@jtibshirani
Copy link
Contributor Author

Thanks @romseygeek for the review! I had to fix some test issues in the base branch object-fields, but didn't add any new changes after your review.

@jtibshirani jtibshirani merged commit 6a2375b into elastic:object-fields Mar 12, 2019
@jtibshirani jtibshirani deleted the field-type-lookup branch March 12, 2019 02:33
jtibshirani added a commit that referenced this pull request Mar 14, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request Mar 19, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit to jtibshirani/elasticsearch that referenced this pull request Mar 19, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request Mar 28, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request Apr 10, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request Apr 17, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request May 1, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request May 24, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
jtibshirani added a commit that referenced this pull request May 29, 2019
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants